FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add default color CSS selectors to node text by ibdafna · Pull Request #1447 · bqplot/bqplot · GitHub

/ bqplot Public

Add default color CSS selectors to node text - #1447

Merged
martinRenou merged 4 commits into
bqplot:masterfrom
ibdafna:node_text_color
Feb 10, 2022
ConversationCommits (4)ChecksFiles changed
Merged

Add default color CSS selectors to node text#1447
martinRenou merged 4 commits into
bqplot:masterfrom
ibdafna:node_text_color

Conversation

ibdafna commented Jan 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Itay Dafna idafna@seas.upenn.edu

  • Add default CSS selectors for dark and light themes
  • Add node_text_color traitlet to Graph object (will do this in a separate PR)

Visual regressions tests will likely need to be updated for Node objects as default text color for dark theme is now lighter.

ibdafna commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

update galata references

ibdafna commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

update galata references

ibdafna requested a review from martinRenou February 10, 2022 06:22
martinRenou reviewed Feb 10, 2022
View reviewed changes

martinRenou left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Looking at the visual diffs, this has an impact on the text color in nodes, should we keep the text in nodes black?

ibdafna commented Feb 10, 2022 via email

Copy link
Copy Markdown
Member Author

martinRenou commented Feb 10, 2022

Copy link
Copy Markdown
Member

Makes sense, thanks!

martinRenou merged commit 4055890 into bqplot:master Feb 10, 2022

martinRenou commented Feb 10, 2022

Copy link
Copy Markdown
Member

meeseeksdev please backport to 0.12.x

lumberbot-app Bot commented Feb 10, 2022

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 4055890117c3ebd49da67b9bc8e0c03f1e91480f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1447: Add default color CSS selectors to node text'
  1. Push to a named branch:
git push YOURFORK 0.12.x:auto-backport-of-pr-1447-on-0.12.x
  1. Create a PR against branch 0.12.x, I would have named this PR:

"Backport PR #1447 on branch 0.12.x (Add default color CSS selectors to node text)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou pushed a commit to martinRenou/bqplot that referenced this pull request Feb 10, 2022
Add default color CSS selectors to node text (bqplot#1447)
ad36b02 
* Add default color CSS selectors to node text

Signed-off-by: Itay Dafna <idafna@seas.upenn.edu>

* Run lint

* Update Galata References

* Update Galata References

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

martinRenou commented Feb 10, 2022

Copy link
Copy Markdown
Member

meeseeksdev please backport to 0.12.x

meeseeksmachine pushed a commit to meeseeksmachine/bqplot that referenced this pull request Feb 10, 2022
Backport PR bqplot#1447: Add default color CSS selectors to node text
0e675a9
meeseeksmachine mentioned this pull request Feb 10, 2022
Merged
martinRenou added a commit that referenced this pull request Feb 10, 2022
Merge pull request #1473 from meeseeksmachine/auto-backport-of-pr-144…
3068b85 
…7-on-0.12.x

Backport PR #1447 on branch 0.12.x (Add default color CSS selectors to node text)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

martinRenou martinRenou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL