FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: line label invisible in dark theme by mariobuikhuizen · Pull Request #1465 · bqplot/bqplot · GitHub

/ bqplot Public

fix: line label invisible in dark theme - #1465

Merged
martinRenou merged 3 commits into
bqplot:masterfrom
mariobuikhuizen:fix_line_label_invisible_in_dark_theme
Feb 9, 2022
ConversationCommits (3)ChecksFiles changed
Merged

fix: line label invisible in dark theme#1465
martinRenou merged 3 commits into
bqplot:masterfrom
mariobuikhuizen:fix_line_label_invisible_in_dark_theme

Conversation

mariobuikhuizen commented Feb 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

To reproduce:

from bqplot import *


x = LinearScale()
y = LinearScale()

line = Lines(x=[0], 
             y=[0],
             scales={'x': x, 'y': y},
             labels=['My label'],
             labels_visibility='label')
ax_x = Axis(scale=x, label='X')
ax_y = Axis(scale=y, label='Y', orientation='vertical')

Figure(marks=[line], axes=[ax_x, ax_y])
Light Dark

With this PR:

mariobuikhuizen added a commit to mariobuikhuizen/jdaviz that referenced this pull request Feb 9, 2022
fix: workaround for invisible line label in dark theme
afd5429 
Can be removed when bqplot/bqplot#1465 is
released.
mariobuikhuizen added a commit to mariobuikhuizen/jdaviz that referenced this pull request Feb 9, 2022
fix: workaround for invisible line label in dark theme
5231f97 
Can be removed when bqplot/bqplot#1465 is
released.
mariobuikhuizen mentioned this pull request Feb 9, 2022
Merged
9 tasks

martinRenou commented Feb 9, 2022

Copy link
Copy Markdown
Member

Thanks!

maartenbreddels commented Feb 9, 2022

Copy link
Copy Markdown
Member

@martinRenou do you think it's worth adding a visual test? I'm ok with the PR as it is.

martinRenou commented Feb 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I was about to ask adding a small visual test :) You can probably add a cell that adds a label in https://github.com/bqplot/bqplot/blob/master/ui-tests/tests/notebooks/scatter_update.ipynb. After that you can trigger the bot to update the test references by commenting "update galata references" in the PR.

martinRenou commented Feb 9, 2022

Copy link
Copy Markdown
Member

Let's backport this as well once it's merged

mariobuikhuizen commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

update galata references

maartenbreddels commented Feb 9, 2022

Copy link
Copy Markdown
Member

@martinRenou is it normal that CI doesn't run after the update of galata? so can we now merge this?

martinRenou commented Feb 9, 2022

Copy link
Copy Markdown
Member

Yeah commits generated from the Github bot are not triggering the CI (I read in the Github docs that this was to prevent an infinite loop of triggering CI, there might be a way to enable it). Closing/reopening to trigger it for now.

martinRenou closed this Feb 9, 2022
martinRenou reopened this Feb 9, 2022

martinRenou commented Feb 9, 2022

Copy link
Copy Markdown
Member

meeseeksdev please backport to 0.12.x

lumberbot-app Bot commented Feb 9, 2022

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 78bf294ad1c33f1df7fd8ecafae40f93da28f2bc
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1465: fix: line label invisible in dark theme'
  1. Push to a named branch:
git push YOURFORK 0.12.x:auto-backport-of-pr-1465-on-0.12.x
  1. Create a PR against branch 0.12.x, I would have named this PR:

"Backport PR #1465 on branch 0.12.x (fix: line label invisible in dark theme)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou merged commit 71e7cd8 into bqplot:master Feb 9, 2022

martinRenou commented Feb 9, 2022

Copy link
Copy Markdown
Member

Thanks!

martinRenou pushed a commit to martinRenou/bqplot that referenced this pull request Feb 10, 2022
Backport PR bqplot#1465: fix: line label invisible in dark theme
dc41da3

martinRenou commented Feb 10, 2022

Copy link
Copy Markdown
Member

meeseeksdev please backport to 0.12.x

lumberbot-app Bot commented Feb 10, 2022

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 71e7cd86746b8ec7674a02e2816cdd3c8364ac19
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1465: fix: line label invisible in dark theme'
  1. Push to a named branch:
git push YOURFORK 0.12.x:auto-backport-of-pr-1465-on-0.12.x
  1. Create a PR against branch 0.12.x, I would have named this PR:

"Backport PR #1465 on branch 0.12.x (fix: line label invisible in dark theme)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou commented Feb 10, 2022

Copy link
Copy Markdown
Member

meeseeksdev please backport to 0.12.x

meeseeksmachine pushed a commit to meeseeksmachine/bqplot that referenced this pull request Feb 10, 2022
Backport PR bqplot#1465: fix: line label invisible in dark theme
b68b00e
meeseeksmachine mentioned this pull request Feb 10, 2022
Merged

martinRenou commented Feb 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

We'll never get replaced by machines for sure 😄 Sorry for the noise on this PR.

martinRenou added a commit that referenced this pull request Feb 10, 2022
Merge pull request #1472 from meeseeksmachine/auto-backport-of-pr-146…
ac74eff 
…5-on-0.12.x

Backport PR #1465 on branch 0.12.x (fix: line label invisible in dark theme)
kecnry pushed a commit to kecnry/jdaviz that referenced this pull request Feb 10, 2022
fix: workaround for invisible line label in dark theme
e8ca844 
Can be removed when bqplot/bqplot#1465 is
released.
kecnry pushed a commit to kecnry/jdaviz that referenced this pull request Feb 10, 2022
fix: workaround for invisible line label in dark theme
497aff1 
Can be removed when bqplot/bqplot#1465 is
released.

pllim commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

Hi. What release will this patch be in and when is the release expected to come out? Thanks!

pllim mentioned this pull request Feb 10, 2022
Merged
25 tasks

martinRenou commented Feb 10, 2022

Copy link
Copy Markdown
Member

Hey :) It will be included in the next 0.12.x release. I will do it soonish.

pllim commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

Please let me know the value of x when that happens so we can properly pin it downstream. Thank you! 🙏

martinRenou commented Feb 11, 2022

Copy link
Copy Markdown
Member

@pllim bqplot 0.12.33 is out :)

pllim added a commit to pllim/jdaviz that referenced this pull request Feb 14, 2022
MNT: Bump bqplot minversion to 0.12.33
c6d5595 
to get bqplot/bqplot#1465
pllim mentioned this pull request Feb 14, 2022
Merged
9 tasks

pllim commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

Thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL