FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Plotting Widgets by ChakriCherukuri · Pull Request #1505 · bqplot/bqplot · GitHub

/ bqplot Public

Plotting Widgets - #1505

Merged
martinRenou merged 11 commits into
bqplot:masterfrom
ChakriCherukuri:radar
Sep 29, 2022
ConversationCommits (11)ChecksFiles changed
Merged

Plotting Widgets#1505
martinRenou merged 11 commits into
bqplot:masterfrom
ChakriCherukuri:radar

Conversation

ChakriCherukuri commented Jul 5, 2022

Copy link
Copy Markdown
Member

Added plotting widgets module which contains compound plotting widgets which subclass Figure

ibdafna commented Jul 17, 2022

Copy link
Copy Markdown
Member

Will review this week.

ibdafna commented Jul 21, 2022

Copy link
Copy Markdown
Member

@ChakriCherukuri issue seems to be upstream with traittypes:

https://github.com/jupyter-widgets/traittypes/blob/af2ebeec9e58b73a12d4cf841bd506d6eadb8868/traittypes/traittypes.py#L185

The dType is defined there in the constructor.

ljcno3 commented Jul 21, 2022

Copy link
Copy Markdown

Please unsubscribe me from this Thx

ibdafna commented Jul 21, 2022

Copy link
Copy Markdown
Member

Please unsubscribe me from this Thx

Hi there, no one subscribed you - only you can subscribe yourself to updates. Check if you're following the repo or something like that. There's nothing we can do for you on our end. Thanks!

ljcno3 commented Jul 21, 2022 via email

Copy link
Copy Markdown

ChakriCherukuri commented Jul 27, 2022

Copy link
Copy Markdown
Member Author

@martinRenou can you please advise how to fix the traittypes warnings? thx

martinRenou commented Jul 27, 2022

Copy link
Copy Markdown
Member

All I can do I guess is delete my GitHub account 🙁

This sounds a bit radical ahah. You have an "unsubscribe" link in the email you received, maybe clicking it could help: https://github.com/notifications/unsubscribe-auth/ADCNFJORYFEFETBAP3742E3VVGJLPANCNFSM52XMT7BQ

@ChakriCherukuri Sure I'll try to find time to have a look

ibdafna commented Jul 27, 2022 via email

Copy link
Copy Markdown
Member

ChakriCherukuri commented Aug 2, 2022

Copy link
Copy Markdown
Member Author

@chakri I pointed out where the issue is above. We'll need an upstream PR to traittypes
…
On Wed, Jul 27, 2022, 16:35 martinRenou @.> wrote: All I can do I guess is delete my GitHub account 🙁 This sounds a bit radical ahah. You have an "unsubscribe" link in the email you received, maybe clicking it could help: https://github.com/notifications/unsubscribe-auth/ADCNFJORYFEFETBAP3742E3VVGJLPANCNFSM52XMT7BQ @ChakriCherukuri https://github.com/ChakriCherukuri Sure I'll try to find time to have a look — Reply to this email directly, view it on GitHub <#1505 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZICWPZON33GW2H6XOPWV3VWFCLLANCNFSM52XMT7BQ . You are receiving this because your review was requested.Message ID: @.>

So @ibdafna can you merge it then?

martinRenou reviewed Aug 4, 2022
View reviewed changes
Comment thread bqplot/plotting_widgets.py
Comment on lines +119 to +123
t = np.linspace(0, 2 * np.pi, 1000)
band_data_x, band_data_y = (
self.scaled_band_data * np.cos(t),
self.scaled_band_data * np.sin(t),
)

martinRenou Aug 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It would be nice to have a Circle primitive (similar to the Lines one), so we don't need to create a circle based on a thousand segments.

This would be more efficient as it would mean sending 3 float values (center + radius) instead of 2000 float values to the front-end.

Just adding this as a note, I don't think we should block this PR waiting for such a primitive.

ChakriCherukuri commented Aug 12, 2022

Copy link
Copy Markdown
Member Author

@ibdafna @martinRenou can we please merge this if we are OK with the warnings?

ChakriCherukuri commented Aug 19, 2022

Copy link
Copy Markdown
Member Author

@martinRenou I reverted the code to use an empty DataFrame constructor. Can you please review? Thx

ChakriCherukuri commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

@martinRenou can you please merge if this looks good?

martinRenou commented Sep 1, 2022

Copy link
Copy Markdown
Member

Thanks! We should get the CI green before merging

martinRenou merged commit 4a5b341 into bqplot:master Sep 29, 2022

martinRenou commented Sep 29, 2022

Copy link
Copy Markdown
Member

meeseeksdev please backport to 0.12.x

meeseeksmachine pushed a commit to meeseeksmachine/bqplot that referenced this pull request Sep 29, 2022
Backport PR bqplot#1505: Plotting Widgets
5c2e0e5
meeseeksmachine mentioned this pull request Sep 29, 2022
Merged
martinRenou added a commit that referenced this pull request Sep 29, 2022
Merge pull request #1530 from meeseeksmachine/auto-backport-of-pr-150…
f41bbae 
…5-on-0.12.x

Backport PR #1505 on branch 0.12.x (Plotting Widgets)
maartenbreddels pushed a commit to maartenbreddels/bqplot that referenced this pull request Feb 24, 2023
Backport PR bqplot#1505: Plotting Widgets
4b09017
maartenbreddels pushed a commit to maartenbreddels/bqplot that referenced this pull request Mar 14, 2023
Backport PR bqplot#1505: Plotting Widgets
6b96051
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ibdafna Awaiting requested review from ibdafna
martinRenou Awaiting requested review from martinRenou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL