fix: axis formatting depended on initial values or changes - #1541
Merged
maartenbreddels merged 1 commit intoApr 11, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
7 tasks
maartenbreddels
force-pushed
the
fix_axis_formatting
branch
from
28785ba to
894eacd
Compare
February 21, 2023 13:09
maartenbreddels
force-pushed
the
fix_axis_formatting
branch
3 times, most recently
from
bf5e533 to
429780c
Compare
March 28, 2023 17:56
maartenbreddels
force-pushed
the
fix_axis_formatting
branch
from
429780c to
24cdd45
Compare
April 11, 2023 11:32
The codepath to to axis formatting for the initial values was different from when properties such as tick_values are updated afterwards. This was probably due to some technical debt/circular dependency in the code. If did the minimal amount of change to make sure the behaviour is the same, while having a consistent codepath.
maartenbreddels
force-pushed
the
fix_axis_formatting
branch
from
24cdd45 to
74c2ab8
Compare
April 11, 2023 12:38
Copy link
Copy Markdown
Member
Author
|
meeseeksdev backport to 0.12.x |
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/bqplot
that referenced
this pull request
Apr 11, 2023
maartenbreddels
added a commit
that referenced
this pull request
Apr 11, 2023
… changes (#1597) Co-authored-by: Maarten Breddels <maartenbreddels@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codepath to to axis formatting for the initial values was different from when properties such as tick_values are updated afterwards.
This was probably due to some technical debt/circular dependency in the code.
If did the minimal amount of change to make sure the behaviour is the same, while having a consistent codepath.
Fixes #1536