| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Is the CI failure related? |
Sorry, something went wrong.
|
No, I think we need to port #1550 to the 0.12.x branch first |
Sorry, something went wrong.
|
@mariobuikhuizen can you rebase now that #1550 is in? |
Sorry, something went wrong.
In Firefox and Safari, panning doesn't work correctly when a plots parent is rotated by CSS.
|
Ah, I can do that from the github UI :) |
Sorry, something went wrong.
|
Great work mario, GPT4 and Maarten approved :) |
Sorry, something went wrong.
|
meeseeksdev please backport to master |
Sorry, something went wrong.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout master git pull
git cherry-pick -x -m1 02fdfde10ad1708959bc25fffd49260adbb662fb
git commit -am "Backport PR #1585: fix: panning in a by CSS rotated plot doesn't work correctly"
git push YOURFORK master:auto-backport-of-pr-1585-on-master
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the Still Needs Manual Backport label once the PR gets merged. If these instructions are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
…t work correctly (bqplot#1585) In Firefox and Safari, panning doesn't work correctly when a plots parent is rotated by CSS. (cherry picked from commit 02fdfde)
| Back | FazBrowse Home | New Git URL |
In Firefox and Safari, panning doesn't work correctly when a plot's parent is rotated by CSS.
The panning issue is caused by getScreenCTM() in https://github.com/d3/d3-selection/blob/679346930e41a4037ef72d937b425bbe4d865ab1/src/point.js#L7, which doesn't take the viewport transforms into account in Firefox (https://stackoverflow.com/questions/71368779/svg-getscreenctm-does-not-account-for-css-transforms-in-firefox) and Safari
As seen here: spacetelescope/jdaviz#1384 (comment)
To reproduce, run the following code in Firefox or Safari:
References
Code changes
This commit checks whether the browser is not Chrome and has a rotated parent, then determines the mouse position differently.
User-facing changes
Panning now also works correctly for non-Chrome browsers for plots with CSS rotated parents, with a small difference in behavior: panning stops if the mouse leaves the plot element.