Set BREF_STACK_NAME on PHP functions - #18
Open
mnapoli wants to merge 1 commit into
Open
mnapoli wants to merge 1 commit into
mnapoli wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The Bref plugin sets this variable on `serverless.yml` deployments (brefphp/bref#2184), and Bref Cloud on `bref.php` deployments (brefphp/cloud#388). CDK applications get the same variable, unless they set it themselves. Claude-Session: https://claude.ai/code/session_01MAbMtQ3io736HaRVpwKzCD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bref now sets a BREF_STACK_NAME environment variable containing the stack name on all functions deployed with serverless.yml (brefphp/bref#2184) and with Bref Cloud's bref.php (brefphp/cloud#388). This PR does the same for CDK applications, so that the variable is available whatever the deployment method.
With the stack name, an application can find resources named after the stack. For example, the Laravel bridge exposes it as config('bref.stack_name') (brefphp/laravel-bridge#211) to route Laravel queue names to SQS queues with Queue::forward(). With CDK, that only works if the application names its SQS queues <stack>-<name>, like Lift and Bref Cloud do.
PhpFunction and PhpFpmFunction set it to Stack.of(this).stackName, and ConsoleFunction inherits it from PhpFunction. A BREF_STACK_NAME passed in the function's environment is kept, like with the plugin.