FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

f4: scope turbo typecheck to browsercode-packages filter by Alezander9 · Pull Request #2 · browser-use/browsercode · GitHub

f4: scope turbo typecheck to browsercode-packages filter - #2

Merged
Alezander9 merged 1 commit into
mainfrom
f4-turbo-filter-browsercode-packages
Apr 23, 2026
Merged

Alezander9 merged 1 commit into
mainfrom
f4-turbo-filter-browsercode-packages

Conversation

Copy link
Copy Markdown
Contributor

Summary

Implements ROADMAP F4. One-line change to root package.json: scope bun turbo typecheck to the packages we actually ship.

Before:

"typecheck": "bun turbo typecheck"

Runs on all 23 packages. Occasional upstream type errors in packages we don't ship (e.g. @opencode-ai/enterprise/src/custom-elements.d.ts) forced git push --no-verify.

After:

"typecheck": "bun turbo typecheck --filter='@browser-use/browsercode-core...' --filter='@browser-use/bcode-browser'"

Scope: 5 packages — @browser-use/browsercode-core plus its deps (shared, plugin, sdk, script) plus @browser-use/bcode-browser.

Filter syntax note

pkg... (trailing dots) = "pkg and its deps". ...pkg (leading dots) is the opposite — "pkg and its dependents" — which incorrectly pulls in @opencode-ai/web because web depends on our core. Easy to get backwards; calling it out here for future reference.

@browser-use/bcode-browser is filtered explicitly because nothing depends on it yet. Once A2 lands and packages/opencode has a workspace dep on it, the filter collapses to one line (--filter='@browser-use/browsercode-core...').

Verification

  • bun typecheck now runs on 5 packages: browsercode-core, bcode-browser, plugin, sdk, shared. All pass.
  • script is in scope but has no typecheck task so turbo skips it cleanly.
  • Wall time: ~5s cold, <4s warm, 1s full-turbo cache hit.
  • Husky pre-push hook now works without --no-verify — this push is the proof.

What we're NOT doing

  • Not deleting any package.
  • Not editing upstream source files (zero diff against upstream).
  • Not preventing ad-hoc work on filtered packages (bun --cwd packages/enterprise dev still works).

Reversible with a one-line filter edit.

Follow-ups

Before: bun turbo typecheck ran on all 23 packages, pulling in upstream SaaS,
GUI, and standalone packages we don't ship. Occasional upstream type errors in
those packages (e.g. @opencode-ai/enterprise/src/custom-elements.d.ts as noted
in CLOUD_DEV_SETUP.md workaround #1) forced `git push --no-verify`.

After: filtered to our CLI plus everything it depends on (@browser-use/
browsercode-core... expands to shared + plugin + sdk + script transitively),
plus @browser-use/bcode-browser (the Level-1 package from decisions.md §1d,
not yet a transitive dep of opencode until ROADMAP A2 lands).

Scope: 5 packages. Time: ~5s cold, <4s warm. Zero upstream diff.

Filter syntax note: `pkg...` (trailing dots) means "pkg and its deps".
`...pkg` (leading dots) is the opposite — "pkg and its dependents" — which
incorrectly pulls in @opencode-ai/web because web depends on our core.

Reversibility: adding a package back is one line in the --filter list.

See decisions.md §1b (prefer filtering over deletion), ROADMAP F4, and
memory/browsercode/packages_inventory.md for the rationale.
Alezander9 merged commit d2f3411 into main Apr 23, 2026
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL