FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add SYNC.md protocol for upstream sync by Alezander9 · Pull Request #4 · browser-use/browsercode · GitHub

docs: add SYNC.md protocol for upstream sync - #4

Merged
Alezander9 merged 1 commit into
mainfrom
docs/sync-protocol
Apr 23, 2026
Merged

Alezander9 merged 1 commit into
mainfrom
docs/sync-protocol

Conversation

Copy link
Copy Markdown
Contributor

Summary

Codifies the 7-step upstream sync protocol that was first executed live in PR #3. Future maintenance agents follow SYNC.md; they don't re-derive. Complements UPSTREAM.md (the sync log + modification zones) — SYNC.md is the how; UPSTREAM.md is the why and the record.

What's in it

  • Why merge commits, not rebase (forks ingesting upstream).
  • Why anchor on the commit on upstream/dev instead of the release tag commit (tags are siblings of dev, not ancestors).
  • Prerequisites (upstream remote, PAT, bun version).
  • 7-step protocol: clean main → drift check → branch + merge → install + typecheck → Yellow-zone audit → update UPSTREAM.md → commit + push + PR.
  • Typical conflict set with resolution rules (keep our name, take their version; --theirs bun.lock then regenerate).
  • PR body template.
  • Troubleshooting section addressing three real issues hit in PR sync: upstream v1.14.22 (eb7555d3c on dev) #3.

Friction this PR addresses (from PR #3 reflection)

Friction Fix in SYNC.md
Branch hygiene — session started on a stale branch, main was behind origin Step 1 is explicitly git checkout main && git pull origin main
gh pr create fails (GraphQL path PAT does not cover) Step 7 documents REST curl command; notes the PAT details (user Alezander9, fine-grained scope) so it's not re-debugged.
Pre-push hook required --no-verify (bun version guard) Prerequisites call out the packageManager pin; Troubleshooting says "upgrade bun, don't patch the hook". Sprite bun was upgraded 1.3.11 → 1.3.13 this session; this PR's own push ran the hook clean, no --no-verify.

Not addressed here

SYNC.md is agent-facing. It does not replace anything in AGENTS.md; it's referenced alongside UPSTREAM.md as the sync-specific runbook.

Verification

This PR's own push exercised the full protocol end-to-end:

  • git checkout main && git pull clean.
  • bun install clean.
  • bun run typecheck 5/5 cached pass in ~1s.
  • Pre-push hook passed without --no-verify.
  • PR opened via REST (the path SYNC.md documents).

Codifies the 7-step protocol first executed in PR #3 so future
maintenance agents don't re-derive it. Complements UPSTREAM.md
(the sync log + modification zones) — SYNC.md is the how,
UPSTREAM.md is the why and the record.

Incorporates friction fixes surfaced by PR #3:
- Step 1 is explicitly 'git checkout main && git pull origin main'
  so stale-main doesn't silently produce a stale sync.
- Step 7 documents that gh pr create fails against our PAT via
  GraphQL but REST works; includes the curl command. Notes
  user+scope so this is not re-debugged.
- Troubleshooting section calls out the bun-version guard in
  husky/pre-push and the fix (upgrade bun, don't patch the hook).

Also documents merge-commit rationale, release-tag vs dev-commit
anchoring, typical conflict set with resolution rules, Yellow-zone
audit grep, and PR body template.
Alezander9 merged commit 8b0614d into main Apr 23, 2026
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL