☒ Fix race condition - make on_frame_navigated callback async - #175
Open
filip-michalsky wants to merge 3 commits into
Open
☒ Fix race condition - make on_frame_navigated callback async#175filip-michalsky wants to merge 3 commits into
filip-michalsky wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
☒ Fix memory leak - cleanup CDP session on page close
☒ Fix weak reference consistency for frame_id_map
☐ Add null check for context before using frame_id
☐ Add CDP failure scenario tests
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
what changed
test plan