Add support for the Node v6 preserve-symlinks option - #1742
Merged
goto-bus-stop merged 1 commit intoJan 31, 2018
Merged
goto-bus-stop merged 1 commit into
goto-bus-stop merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
When specified, symlinks are preserved when resolving modules. Specifically, the `realpath` call is skipped. This allows symlinked peer dependencies to work correctly. Matches the behavior of the option added in node v6.3.0: https://nodejs.org/api/cli.html#cli_preserve_symlinks.
Copy link
Copy Markdown
Member
Author
|
@substack @feross who is maintaining browserify these days? Can someone look at this? |
Sorry, something went wrong.
mightyaleksey
pushed a commit
to css-modules/postcss-modules-resolve-imports
that referenced
this pull request
Sep 5, 2017
mightyaleksey
pushed a commit
to css-modules/postcss-modules-resolve-imports
that referenced
this pull request
Sep 5, 2017
Copy link
Copy Markdown
Member
|
makes sense, thanks! reading the node thread it seems like entry points would be realpath()ed regardless, does this patch need to do anything handle that? |
Sorry, something went wrong.
This was referenced May 29, 2021
This was referenced Jun 6, 2021
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specified, symlinks are preserved when resolving modules. Specifically, the realpath call is skipped. This allows symlinked peer dependencies to work correctly. Matches the behavior of the option added in node v6.3.0: https://nodejs.org/api/cli.html#cli_preserve_symlinks. See nodejs/node#3402 for discussion around this feature in node.