Failing test + fix for backtick quotes - #1785
Merged
goto-bus-stop merged 2 commits intoJan 4, 2018
Merged
goto-bus-stop merged 2 commits into
goto-bus-stop merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
in https://github.com/browserify/detective even, i think. thanks for working on this :D |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'll update this to use module-deps@2.x and then it should be good. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Bumping the dependency on module-deps guarantees that the backtick-supporting version of detective will be used. The tests fail in 0.10 and 0.12 because detective doesn't support those versions any more. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
merging since the failures are only on node <4 and tests will pass on master. thanks! |
Sorry, something went wrong.
1 task
This was referenced Jun 1, 2021
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1782
This issue needs to be fixed in module-deps. I will open a pull request there.