FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix support for node v0.8 support by kumavis · Pull Request #1939 · browserify/browserify · GitHub

/ browserify Public

Fix support for node v0.8 support - #1939

Merged
ljharb merged 3 commits into
browserify:masterfrom
kumavis:fix-v0.8
Dec 28, 2019
ConversationCommits (3)ChecksFiles changed
Merged

Fix support for node v0.8 support#1939
ljharb merged 3 commits into
browserify:masterfrom
kumavis:fix-v0.8

Conversation

kumavis commented Dec 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

kumavis mentioned this pull request Dec 28, 2019
Merged
ljharb reviewed Dec 28, 2019
View reviewed changes
Comment thread package.json Outdated
Comment thread package.json Outdated
kumavis and others added 2 commits December 28, 2019 11:44
Update package.json
6c1fa0b 
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Update package.json
27391a4 
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
ljharb added the bug label Dec 28, 2019

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

I also noticed appveyor and travis tests dont have the same engine coverage...

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

would be nice to document supported platforms for both browserify and bundles

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

also if we could turn on greenkeeper for only in-range dep updates? would give us an idea if our deps break

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

woof appveyor takes forever

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

@ljharb finished cooking

ljharb commented Dec 28, 2019

Copy link
Copy Markdown
Member

We should definitely make sure “engines” is set correctly, as are CI matrices.

ljharb merged commit b0e452c into browserify:master Dec 28, 2019
kumavis deleted the fix-v0.8 branch December 28, 2019 04:46
goto-bus-stop mentioned this pull request Jan 9, 2020
Closed
This was referenced Apr 21, 2020
Closed
Open
Merged
This was referenced May 2, 2020
Open
Open
Open
ghost reviewed Aug 2, 2020
View reviewed changes

ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

package.json###

dependabot Bot mentioned this pull request Mar 13, 2021
Open
This was referenced May 29, 2021
Open
Open
Open
Merged
Open
renovate Bot mentioned this pull request Jun 6, 2021
Open
1 task
This was referenced Jun 6, 2021
Closed
Merged
Merged
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Closed
Closed
Open
Closed
renovate Bot mentioned this pull request Jun 14, 2021
Merged
1 task
mend-for-github-com Bot mentioned this pull request Jul 5, 2021
Open
1 task
renovate Bot mentioned this pull request Jul 8, 2021
Open
1 task
bee22193 mentioned this pull request Jun 21, 2024
Open
bee22193 mentioned this pull request Jul 19, 2024
Open
bee22193 mentioned this pull request Aug 21, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
Open
This was referenced Sep 20, 2024
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL