Use 'global' instead of window. Fixes #36 - #37
Open
kumavis wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
Any idea when this one might land? I need this for jsdom/jsdom#711. Is there anything I can do to help move things along? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@lawnsea The monkey-patch is global.window = global at the top of your worker src |
Sorry, something went wrong.
lawnsea
referenced
this pull request
in TreehouseJS/jsdom
Aug 11, 2014
To run the tests: `node test/browser-runner.js`. The runner accepts the same options as `test/runner`, as well as some optional arguments that control the test setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global is provided by browserify to be window in normal windows or self in workers
Fixes #36