| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I think it is a bad idea to change the default on such an important flag without a major version bump, or at least minor. Though I would say if this was a fresh project that withCredentials should be false by default. |
Sorry, something went wrong.
|
As discussed at naugtur/xhr#33 (click "Show outdated diff"), some believe the withCredentials default in the spec was a mistake, as was the Access-Control-Allow-Origin wildcard. I haven't found many resources to back this up, however. The commented text at http://enable-cors.org/server_nginx.html suggests this, but others (including http://fetch.spec.whatwg.org/#basic-safe-cors-protocol-setup) seem to favor the wildcard and the default of false. |
Sorry, something went wrong.
|
I would like to see this merged since withCredentials default to true prevents accessing resources on many servers and the solution might not be obvious for users. Especially if your like me using http-browserify through request browserified. Resources examples: |
Sorry, something went wrong.
|
Please merge. The current default behavior is totally unexpected. |
Sorry, something went wrong.
|
Holy shit, please merge. That took me forever to figure out. |
Sorry, something went wrong.
|
Any update on if/when this will get merged? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Any reason to alter the default for xhr.withCredentials?