Support GLOBAL in addition to global - #8
Open
ELLIOTTCABLE wants to merge 1 commit into
Open
ELLIOTTCABLE wants to merge 1 commit into
ELLIOTTCABLE wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
using globals is a rude and obnoxious thing, so it's appropriate to be in all caps. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
It's also amusing to note here that your user-name is capslocked! |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@dominictarr I would place myself in the same category as GLOBALS. ;) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Indeed. I admire your consistency! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Also, there is a root global in Node, pointing to global. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node provides the GLOBAL variable as well as global. Browserify, thus, should support this also.
Forgive me if I went about this the wrong way; I'm not thoroughly familiar with Browserify's structure. If there's other modules I need to change to make this work, let me know.