Fix example - #78
Open
Chaitya62 wants to merge 5 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@singh811 Is there some issue with the master, I have changed the readme still the CI failed ? Also regarding my example: is the
|
Sorry, something went wrong.
nimit95
reviewed
Jun 18, 2019
Comment thread
README.md
Outdated
yashLadha
reviewed
Jan 23, 2020
Comment thread
README.md
| if (bs_local.isRunning()) { | ||
|
|
||
| // run your test here | ||
| yourTest(function() { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Maybe using a much more contextual name like testScenario or something on these lines?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example in async style.