FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Error Type in callback by yashLadha · Pull Request #95 · browserstack/browserstack-local-nodejs · GitHub

/ browserstack-local-nodejs Public

Error Type in callback - #95

Open
yashLadha wants to merge 1 commit into
browserstack:masterfrom
yashLadha:chore/errorCallback_type
ConversationCommits (1)ChecksFiles changed
Open

Error Type in callback#95
yashLadha wants to merge 1 commit into
browserstack:masterfrom
yashLadha:chore/errorCallback_type

Conversation

yashLadha commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

No description provided.

yashLadha force-pushed the chore/errorCallback_type branch from 51e0562 to 90025f9 Compare January 24, 2020 09:12
yashLadha force-pushed the chore/errorCallback_type branch from 90025f9 to 07aa1cb Compare January 24, 2020 10:06
elukoyanov suggested changes Jan 27, 2020
View reviewed changes
Comment thread index.d.ts
[key: string]: string | boolean;
}

type LocalOptions = Partial<Options>;

elukoyanov Jan 27, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't see any another use of LocalOptions.

Why it should be moved to declared type

yashLadha Jan 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

When other frameworks are integrating the options for passing as arguments, they need to have an interface to declare. This is why I have pulled out this.

Comment thread package.json
{
"name": "browserstack-local",
"version": "1.4.5",
"version": "1.4.6",

elukoyanov Jan 27, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is it here?

yashLadha Jan 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Version bump for publishing in new package.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
elukoyanov elukoyanov requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL