FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: FromApp inherits the app-level api {} config into site handlers by jtelo88 · Pull Request #142 · caddyserver/cache-handler · GitHub

/ cache-handler Public

fix: FromApp inherits the app-level api {} config into site handlers #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtelo88 wants to merge 1 commit into
base: master
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 0 Commits 1 Checks 0 Files changed
Open

fix: FromApp inherits the app-level api {} config into site handlers #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .go  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
11 changes: 11 additions & 0 deletions httpcache.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,17 @@ func (s *SouinCaddyMiddleware) FromApp(app *SouinApp) error {
}
}

// The Caddyfile `api {}` block is global-only (parseCaddyfileGlobalOption
// rejects it inside site blocks), so a handler's own configuration can
// only carry an API config via raw JSON. When it doesn't, inherit the
// app-level API like every other app-level default merged below —
// otherwise GenerateHandlerMap sees a zero API config in every handler
// instance and the souin API is unreachable in-band on any listener
// (requests fall through the cache handler as if the API didn't exist).
if !s.Configuration.API.Souin.Enable && !s.Configuration.API.Debug.Enable && !s.Configuration.API.Prometheus.Enable {
s.Configuration.API = app.API
}

if app.GetTTL() == 0 {
if s.Configuration.DefaultCache.GetTTL() == 0 {
app.TTL = configurationtypes.Duration{Duration: 120 * time.Second}
Expand Down
Back | FazBrowse Home | New Git URL