add attribute rules - #396
Merged
dereuromark merged 1 commit intoAug 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Don't know if we want other rules from https://github.com/slevomat/coding-standard/blob/master/doc/attributes.md#slevomatcodingstandardattributesattributesorder- in here as well |
Sorry, something went wrong.
markstory
approved these changes
Aug 11, 2024
markstory
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think these make sense. The ordering and sniffs seem like rules that won't come up that often as we don't use attributes in the framework yet.
Sorry, something went wrong.
ravage84
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that something like this is not allowed:
#[DataProvider('irregularCreateTableProvider')] public function mymethod(): voidThis also forces attribtues to be added bellow the docblock
Refs: cakephp/migrations#736