fix error when phpdoc param has no type - #403
Merged
dereuromark merged 1 commit intoDec 17, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
LordSimal
marked this pull request as draft
December 17, 2024 21:41
LordSimal
force-pushed
the
5.x-fix-error-with-no-type
branch
from
86bf119 to
cd67ba6
Compare
December 17, 2024 21:49
LordSimal
marked this pull request as ready for review
December 17, 2024 21:49
Copy link
Copy Markdown
Member
|
Side note if ($valueNode instanceof InvalidTagValueNode || $valueNode instanceof TypelessParamTagValueNode) {
if (!isset($valueNode->type)) {
$phpcsFile->addWarning('%s type hint is missing', $tag, 'MissingParamType', [$tokens[$tag]['content']]);
}
continue;
}Note the %s, since it can be others than param as well. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402
This adds a new warning if a param type has no type hint instead of just bailing out due to an error