Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hmm.. Trying out this branch with cakephp codebase gives me errors like this one for all slevomat sniffs when running phpcs ERROR: Referenced sniff "SlevomatCodingStandard.Arrays.TrailingArrayComma" does not exist. |
Sorry, something went wrong.
dealerdirect/phpcodesniffer-composer-installer is already an indirect dependency through slevomat/coding-standards. This package avoids having to manually specify the paths to custom phpcs standards.
Copy link
Copy Markdown
Member
Author
|
Fixed above issue |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This is ready for merging. Tested against the core and everything seems fine cakephp/cakephp#18917 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Version-4.0-Developer-Upgrade-Guide