refactor: example app - #5053
Conversation
Sorry, something went wrong.
MikitasK
left a comment
There was a problem hiding this comment.
looks awesome! good job 👍
just a few points to address before merge:
Sorry, something went wrong.
| const resetPreferences = React.useCallback(async () => { | ||
| setShouldUseDynamicTheme(true); | ||
| setIsDarkMode(false); | ||
| setCustomFont(false); | ||
| setRippleEffectEnabled(true); | ||
| setPreferencesVisible(false); |
There was a problem hiding this comment.
what about resetting RTL here as well? currently Reset clears stored preferences but leaves rtl unchanged, so the app can remain in RTL after resetting
I18nManager.forceRTL persists forced direction across restarts
Sorry, something went wrong.
There was a problem hiding this comment.
That one was intentional, RTL in the app requires full app reload. I wanted to keep reset more responsive. That's why no RTL reset. I would keep it that way.
Sorry, something went wrong.
| keyExtractor={({ id }) => id} | ||
| contentContainerStyle={[ | ||
| styles.content, | ||
| { paddingBottom: safeArea.bottom + 16 }, |
There was a problem hiding this comment.
could we also include left & right safe-area insets in horizontal padding?
it's necessary to render list correctly in landscape mode (RN navigation docs)
Sorry, something went wrong.
There was a problem hiding this comment.
Fixed
Sorry, something went wrong.
MikitasK
left a comment
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
Motivation
PR improves example app. It adds:
Related issue
#4992
Test plan
yarn lint, yarn typecheck, yarn test and a visual check of provided screenshots