Tidy up SSL connection to fix deprecation warnings - #86
Conversation
Sorry, something went wrong.
(cherry picked from commit 5e43f39)
There was a problem hiding this comment.
LGTM - brilliant as always @mikemanger - thank you for fixing this. We really appreciate all the work you've done to make this wrapper better.
To test this change we:
✔️ Ran the unit tests, they all pass
✔️ Ran a sample program using the code in this PR, that passed
✔️ Ran tox, below is a picture of the before and after showing that the deprecation warning has been eliminated.
Before/After - Left/Right
We will release this in a new version (9.0.1)
We will take a look at review the issues which we have not paid proper attention to, and see if we can address them. Of course, we welcome any feedback or help along the way to keep improving this API wrapper. A big thank you for all your contributions 🥇
Sorry, something went wrong.
Tidy up SSL connection to fix deprecation warnings
Tidy up SSL connection to fix deprecation warnings
Removes some python 2 checks and fixes deprecation warnings on python 3.10 and above. Fixes #85
I feel the VerifiedHTTPSConnection class should probably be dropped in favour of using urllib3.connection.HTTPSConnection as a dependency - the code in this repository appears to be based on a much earlier version of this class. I don't think it is quite a drop in replacement as we'd need to set the CA file included in this repository.