FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Lists API by sebastiansimson · Pull Request #149 · castle/castle-java · GitHub

Lists API - #149

Merged
sebastiansimson merged 12 commits into
masterfrom
feature/lists-api
Feb 25, 2025
Merged

Lists API#149
sebastiansimson merged 12 commits into
masterfrom
feature/lists-api

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

aalekz self-requested a review February 25, 2025 17:19
aalekz previously approved these changes Feb 25, 2025
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("class BaseItem {\n");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unnecessary empty line?

public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("class ListItemAuthor {\n");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unnecessary new line?

return OpEnum.fromValue((String)(value));
}
}
} @SerializedName("op")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should probably be on a separate line

@Override
public String toString() {
return String.valueOf(value);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

New line

return OpEnum.fromValue((String)(value));
}
}
} @SerializedName("op")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should probably be on a separate line

public void setValue(List<ListQueryFilter> value) {
this.value = value;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

More than one empty line

public int hashCode() {
return Objects.hash(super.hashCode());
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

More than one empty line

}
return null;
}
public static class Adapter extends TypeAdapter<FieldEnum> {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Add new line above

return FieldEnum.fromValue((String)(value));
}
}
} @SerializedName("field")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should probably be on a separate line

}
}
return null;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

New line

sebastiansimson merged commit baca6c0 into master Feb 25, 2025
sebastiansimson deleted the feature/lists-api branch February 25, 2025 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL