fix(php 8.4): Add explicit nullable type - #130
Merged
jschroed91 merged 1 commit intoDec 26, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jschroed91
approved these changes
Dec 26, 2024
jschroed91
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good thank you!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Hi! Is it possible to get a new release for this change to fix deprecation warnings on PHP 8.4? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Yes, please cut a new release. The latest release is from Nov 6, 2023, Thank you |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Could we get a release, pretty please? thanks!! |
Sorry, something went wrong.
christian-kolb
pushed a commit
to vera-contracts/php-htmldiff
that referenced
this pull request
Mar 21, 2025
anwa-waki
added a commit
to vera-contracts/php-htmldiff
that referenced
this pull request
Apr 13, 2026
* Fix: Add explicit nullable type (caxy#130) * php 8.2 (caxy#125) * Correctly match newlines whitin htmltags. (caxy#122) * Correctly match newlines in tags. * Revert regex to current implementation while adding the PCRE_DOTALL modifier. --------- Co-authored-by: Anne Zijlstra <a.zijlstra@iwink.nl> * Removed E_DEPRECATED error explicit nullable types (caxy#132) Co-authored-by: Richard Brinkman <r.brinkman@gmail.com> * Ignore unknown characters in iconv() (caxy#135) Resolves caxy#134 * Fix: Removed some more E_DEPRECATED error explicit nullable types (caxy#133) Co-authored-by: Richard Brinkman <r.brinkman@gmail.com> * Init Claude * Add explanation of modifications --------- Co-authored-by: Lee <8024370+millnut@users.noreply.github.com> Co-authored-by: Steve Ayers <steveneayers@gmail.com> Co-authored-by: pharixces <pharixces@gmail.com> Co-authored-by: Anne Zijlstra <a.zijlstra@iwink.nl> Co-authored-by: richardbrinkman <richardbrinkman@hotmail.com> Co-authored-by: Richard Brinkman <r.brinkman@gmail.com> Co-authored-by: Jürgen Haas <juergen.haas@lakedrops.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some errors in our test pipelines recently with PHP 8.4 and expecting explicit nulllable types.
Would be good to get this merged and released upstream, we are currently using a patch for now.