Resolve PHP 7.3 compatibility issue to fix #79 - #80
Merged
jschroed91 merged 2 commits intoJan 15, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Change the sunra/php-simple-html-dom-parser" for the kub-at/php-simple-html-dom-parser
use KubAT\PhpSimple\HtmlDomParser;
jschroed91
self-requested a review
January 15, 2019 18:57
Copy link
Copy Markdown
Member
|
Looks like scrutinizer failed due to configuration issues - I will fix that on scrutinizer side. Nothing to do on your end @irkallacz |
Sorry, something went wrong.
jschroed91
approved these changes
Jan 15, 2019
jschroed91
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @irkallacz! I will get this merged and tagged
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Sunra\PhpSimple\HtmlDomParser for KubAT\PhpSimple\HtmlDomParser witch is PHP 7.3 compatible.
Tested on system with PHP 7.3