FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Reduce release size by excluding demos and tests. by danepowell · Pull Request #86 · caxy/php-htmldiff · GitHub

/ php-htmldiff Public

Reduce release size by excluding demos and tests. - #86

Merged
jschroed91 merged 1 commit into
caxy:masterfrom
danepowell:reduce-release-size
Sep 27, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Reduce release size by excluding demos and tests.#86
jschroed91 merged 1 commit into
caxy:masterfrom
danepowell:reduce-release-size

Conversation

danepowell commented Jul 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

The size of php-htmldiff on disk is 10MB. This may not sound like much, but that could easily make it the single largest package in any given Composer install. This could be easily reduced to <1MB by simply excluding the demos and tests from packaged releases. Anyone who still wants access to those files would still get them by simply cloning from source, but the thousands of other projects simply using this as a library would save a ton of bandwidth and build time. (literally something like 16TB across the 1.6M installs of this project.)

This is an increasingly common pattern for Composer libraries, following the strategy outlined here.

bobvandevijver commented Jan 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

In my opinion, before this is merged, the demo css should be made available from another path, as it is an easy to use default CSS styling for anyone using the bundle.

Or, even better, maybe it should be offered as SCSS file.

jschroed91 commented Jan 28, 2020

Copy link
Copy Markdown
Member

@danepowell You're very right, we should exclude these for sure. Thanks @bobvandevijver for the note, I agree with that. Will get to this later this week.

mrflos commented Sep 27, 2021

Copy link
Copy Markdown

Hi @jschroed91 !
Any chance this PR will be merged soon?
We want to use it for an open source project called YesWiki but having a 1mb dependency instead of a 10mb one would be great!

jschroed91 commented Sep 27, 2021

Copy link
Copy Markdown
Member

@mrflos Oh, yes let's get this in. I'll take a look after work unless @SavageTiger has any concerns with it, or if he beats me to it

mrflos mentioned this pull request Sep 27, 2021
Merged
5 tasks
jschroed91 merged commit 35e31c5 into caxy:master Sep 27, 2021

jschroed91 commented Sep 27, 2021

Copy link
Copy Markdown
Member

@mrflos This has been merged and included in release v0.1.13 - thank you @danepowell

mrflos commented Sep 28, 2021

Copy link
Copy Markdown

Thank you all very very much!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jschroed91 jschroed91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL