Add preliminary Windows CI - #341
Open
GagaLP wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Check-perf-impact results: (ae6918621b46271c2f10d6eb978fe95d) ❓ No new benchmark data submitted. ❓ |
Sorry, something went wrong.
Copy link
Copy Markdown
Coverage Report for CI Build 31720549177Coverage remained the same at 95.052%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Sorry, something went wrong.
GagaLP
force-pushed
the
ci/windows-clang-cl
branch
5 times, most recently
from
e54af69 to
f1c0e3d
Compare
August 12, 2026 15:45
GagaLP
force-pushed
the
ci/windows-clang-cl
branch
from
9d02c47 to
27761d2
Compare
August 13, 2026 16:24
GagaLP
marked this pull request as ready for review
August 13, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new CI workflow to include Windows in our CI tests. The Windows jobs run on GitHub-hosted runners instead of self-hosted runners.
For now, we focus on compilation and unit tests using SimSYCL and clang-cl. This provides a good first step toward porting and testing Celerity on platforms other than Linux.
The changes are split into four commits:
Add preliminary Windows CI
Adds the CI workflow itself, along with some test fixes required because GitHub-hosted runners currently provide only 4 cores, while some tests require 5. This was likely an oversight, as we already have a similar fix in another part of the test suite.
Add SYSTEM_PATH to dependencies to suppress dependency warnings)
Marks dependency include directories as INTERFACE_SYSTEM_INCLUDE_DIRECTORIES to prevent warnings originating from dependencies. To the best of my knowledge, this is the most platform-independent way to suppress dependency warnings effectively.
Add more flag parity between MSVC and Clang/GCC
Updates the MSVC flags to better match the flags we use with Clang.
Cleanup of unused parameters
Removes old, unused parameters and adds [[maybe_unused]] where parameters are intentionally unused but still required.