FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[GSOC Taks 2] ceph-devstack Cli logs feature : To Display Teuthology Logs by abhi4578 · Pull Request #18 · ceph/ceph-devstack · GitHub

  1. ceph
  2. ceph-devstack

Repository navigation

[GSOC Taks 2] ceph-devstack Cli logs feature : To Display Teuthology Logs - #18

Open
abhi4578 wants to merge 10 commits into
ceph:mainfrom
abhi4578:cli-feature/logs
ConversationCommits (10)ChecksFiles changed
Open

[GSOC Taks 2] ceph-devstack Cli logs feature : To Display Teuthology Logs #18
abhi4578 wants to merge 10 commits into
ceph:mainfrom
abhi4578:cli-feature/logs

Conversation

abhi4578 commented Mar 24, 2025

Copy link
Copy Markdown

Adds implementation of logs and --logs-file option

  • ceph-devstack logs displays latest run
    teuthology logs of given job
  • ceph-devstack logs --log-file displays
    file location of latest run teuthology log of
    given job

Adds pytest unit tests to test 'logs' command

  • Pytest unit tests are added to test new logs command with different
    test cases using parametrized tests and fixtures

abhi4578 changed the title ceph-devstack Cli logs feature : To Display Teuthology Logs [GSOC Taks 2} ceph-devstack Cli logs feature : To Display Teuthology Logs Mar 24, 2025
abhi4578 changed the title [GSOC Taks 2} ceph-devstack Cli logs feature : To Display Teuthology Logs [GSOC Taks 2] ceph-devstack Cli logs feature : To Display Teuthology Logs Mar 24, 2025

abhi4578 commented Mar 24, 2025

Copy link
Copy Markdown
Author

Hello @amathuria @VallariAg @zmc here is my gsoc task 2 logs command implementation on ceph-devstack. Looking forward to your feedback.

abhi4578 commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Disclosure: Github Copilot was used to add doc-strings (like args of function docs/comments) and few one liner python exceptions. Please let me know if this is acceptable or needs to be changed accordingly?

kamoltat reviewed Apr 2, 2025
View reviewed changes

kamoltat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewing

kamoltat reviewed Apr 9, 2025
View reviewed changes

kamoltat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

First round comments for GSOC evaluation, good job! Will not approve the PR since it is just evaluation task.

Comment thread ceph_devstack/resources/test/test_logs.py Outdated
Comment thread ceph_devstack/cli.py Outdated
Comment thread ceph_devstack/cli.py
Comment thread ceph_devstack/cli.py Outdated
Comment thread ceph_devstack/resources/test/test_logs.py Outdated
Comment thread ceph_devstack/cli.py

kamoltat commented Apr 9, 2025

Copy link
Copy Markdown
Member

@abhi4578 also can you please rebase your PR against the main branch thank you

abhi4578 and others added 10 commits April 10, 2025 20:12
Add logs and --log-file option in parse_args
69fe365
Add implementation of logs and --logs-file option
2a2b473 
- ``ceph-devstack logs `` displays latest run
teuthology logs of given job
- ``ceph-devstack logs --log-file `` displace
file location of latest run teuthology log of
given job
Add type hints to teuthology function and comments
e90948e
Adding pytest unit tests to test 'logs' command
22d944b
Update README with 'logs' command
534cb99
Update README.md
8276573 
Signed-off-by: Abhi  <29863835+abhi4578@users.noreply.github.com>
Update ceph_devstack/resources/test/test_logs.py
683b7b0 
Co-authored-by: Kamoltat (Junior) Sirivadhna <ksirivad@gmail.com>
Signed-off-by: Abhi  <29863835+abhi4578@users.noreply.github.com>
Resolving issues raised in review
b48f79f 
- Add appropriate comments for better
  understanding
- Add try, except block while parsing
  latest job directory paths to catch
  ValueError
- Make flag_set to boolean from str
  for simplicity in test_logs.py
- Added chec condition if teuthology.log
  file exists before reading to
  prevent exceptions
Fix teuthology.log file exists and add test cases
3a0626f
Replacing test config yaml file with toml file
fe0f8b8 
- Also replace return statements with exit
  statements in test_logs.py file because
  pytest warnings

abhi4578 commented Apr 10, 2025

Copy link
Copy Markdown
Author

@kamoltat I have added commits resolving the above issues and rebased it against main branch. Please review.

Find the screenshots of

  1. ceph-devstack --logs

  2. ceph-devstack --logs --log-file

  3. Tests python3 -m pytest ceph_devstack/resources/test/test_logs.py

kamoltat approved these changes Apr 14, 2025
View reviewed changes

kamoltat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good work!

abhi4578 commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Good work!

Thank you!

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kamoltat kamoltat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL