Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Zack Cerza <zack@cerza.org>
Fixes: #51 Signed-off-by: Zack Cerza <zack@cerza.org>
zmc
marked this pull request as ready for review
October 7, 2026 20:05
Copy link
Copy Markdown
Collaborator
|
Maybe be use asyncio.create_subprocess_shell and go away from list of arguments? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
right now, including this change, it looks like there are only two places that would invoke a shell so I'd say not yet, but a good idea if it would see more use |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And update our list of supported operating systems.