docs(log-viewer): say what the row mark actually missed - #976
Merged
lcottercertinia merged 1 commit intoAug 28, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
The comment claimed the renderer rebuilds a row scrolled out of view and drops its class. It does not: Row.create() is guarded, Row.initialize() re-uses the element, and our renderer only detaches it. The gap is a row that has never been rendered, so the sweep finds no element to mark.
lcottercertinia
approved these changes
Aug 28, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
#975 explained the row mark with a mechanism that does not exist: that the renderer de-initialises a row scrolled out of view and rebuilds it, dropping the class. A reader who trusts that comment would expect an ordinary scroll to lose a mark, and would look in the wrong place when the mark misbehaves.
What actually happens: Row.create() is guarded by this.created, Row.initialize() deletes cells but re-uses the element, RowManager.styleRow adds and removes parity classes rather than assigning className, and our renderer only detaches and re-attaches the element. A class on a row element survives scrolling. The gap the declarative mark closes is the first render: a row that has never been on screen has no element, so a sweep of what is rendered cannot reach it.
🛠️ Changes made
🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
N/A.
🔗 Related Issues
Corrects comments added in #975.
✅ Tests added?
Comments and one test name. The nine LocatedRowMarker tests still pass unchanged.
📚 Docs updated?
Nothing user-visible changes.
Anything else we need to know? [optional]
No code changes: 6 insertions and 6 deletions, all inside comments and one it title.