fix #18 - #19
Open
felschr wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
zuperglue
reviewed
Feb 6, 2019
Comment thread
index.js
| ret.stderr.indexOf('DEPRECATION:') < 0; | ||
| if (ret.error || (ret.stderr.length != 0 && isNotPipWarning)) { | ||
| this.log('Unhandled error in pip, not deploying to AWS.'); | ||
| return BbPromise.reject(ret.error) |
Copy link
Copy Markdown
There was a problem hiding this comment.
One could consider to change the reject message for errors that is not a warning (undefined when from ret.stderr) .
return BbPromise.reject(ret.error || ret.stderr.toString())
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Ah, I briefly searched for how to differentiate errors from warnings in node.js but couldn't find the solution.
I guess it would be even better to not do the rejection for warnings at all?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error caused by new python 2.7 deprecation warning.