Rename to kebab-case for root action inputs and outputs - #668
Conversation
Sorry, something went wrong.
🦋 Changeset detectedLatest commit: 7d28c47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
| has-changesets: | ||
| description: A boolean about whether there were changesets. Useful if you want to create your own publishing functionality. | ||
| pullRequestNumber: | ||
| pull-request-number: |
There was a problem hiding this comment.
that's pr-number in the /version. perhaps we should match it here?
https://github.com/changesets/action/blob/a35a66bd1ec69b007f5cef9646f34a13eb610a41/src/version/index.ts#L56C19-L56C28
note that it's also missing in the declared outputs of that subaction:
Line 40 in a35a66b
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah we should align the names eventually. In this PR I'd like to focus on kebab-casing only
Sorry, something went wrong.
| required: false | ||
| default: true | ||
| commitMode: | ||
| commit-mode: |
There was a problem hiding this comment.
@beeequeue noticed (rightfully so) this isn't exactly tightly-coupled to committing. But I'm not sure if we have the appetitete to rename this stuff right now
Sorry, something went wrong.
| publish: | ||
| description: "The command to use to build and publish packages" | ||
| required: false | ||
| version: |
There was a problem hiding this comment.
A little bit out of this PR's scope but I feel those should be renamed to publish-script and version-script
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah I can follow up with this later
Sorry, something went wrong.
trueberryless
left a comment
There was a problem hiding this comment.
Looks good to me 🚀
Sorry, something went wrong.
The changesets/action v1->v2 migration (#2714) updated the action's inputs but the workflow still read the action's OUTPUTS by their pre-v2 camelCase names. v2 renamed the outputs to kebab-case too (changesets/action#668). Each read returned an empty string, so `has-changesets` never evaluated to 'false', the "Check if publish is needed" step was skipped, and the publish job's gate failed closed -- release PR #2713 merged and bumped versions but never published to npm. Update the two renamed output reads: - outputs.hasChangesets -> outputs.has-changesets - outputs.publishedPackages -> outputs.published-packages (`published` was not renamed in v2, so it is left as-is.) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Could also rename some to match the new version/publish sub-action names, but I decided to make this change step by step.