Remove GITHUB_TOKEN env var support - #674
Conversation
Sorry, something went wrong.
🦋 Changeset detectedLatest commit: 6f1dfae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
| core.setFailed("Please add the GITHUB_TOKEN to the changesets action"); | ||
| return; | ||
| const githubToken = getRequiredInput("github-token"); | ||
| if (process.env.GITHUB_TOKEN && process.env.GITHUB_TOKEN !== githubToken) { |
There was a problem hiding this comment.
If we have this "they have to match if both are specified" rule - shouldn't we kinda also enforce that in other subactions that use github-token?
Sorry, something went wrong.
There was a problem hiding this comment.
I think this is more for compat to push migration, so eventually in the next major we can remove this and we don't have to mind about GITHUB_TOKEN anymore.
Sorry, something went wrong.
This aligns with the behaviour with the other sub-actions, but with an error if the old pattern is still used.