Split git tag and github release options - #680
Merged
Andarist merged 5 commits intoJul 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
🦋 Changeset detectedLatest commit: 39422af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
Andarist
reviewed
Jun 29, 2026
trueberryless
approved these changes
Jun 30, 2026
trueberryless
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Amazing. Changes look good to me, the logic seems fine. Description matches the behaviour.
Do we have any tests yet for the actions?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Our tests currently is very loose. We should get to that after we're finished with most of the big changes I think. |
Sorry, something went wrong.
Andarist
approved these changes
Jul 1, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #247
fix #547
NOTE: the above issues requested documentation improvements, but I have not done them here yet. I think probably it's easiest to consolidate all the docs update once we've finished reworking the actions & sub-actions.
Possible alternatives
1. I wonder if it should be push-git-tags instead of create-git-tags, because we'd actually only do the pushing. (renamed)
This is a breaking change because create-github-releases: false previously also disabled push tags, but now it'd push by default, unless set push-git-tags: true explicitly.
We can kinda prevent this breaking change by making push-git-tags always follow the value of create-github-releases, unless push-git-tags was explicitly set, but I feel it's a bit hard to follow compared to the current behaviour, where both are independent options, just that create-github-releases: true will always force push-git-tags: true because inherently that's how github releases work.
Or we support some sort of create-github-releases: "tag-only" but this also seems a bit weird.