FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Prettier v3 by beeequeue · Pull Request #1744 · changesets/changesets · GitHub

/ changesets Public

Prettier v3 - #1744

Merged
Andarist merged 6 commits into
changesets:nextfrom
beeequeue:prettier32
Mar 4, 2026
ConversationCommits (6)ChecksFiles changed
Merged

Prettier v3#1744
Andarist merged 6 commits into
changesets:nextfrom
beeequeue:prettier32

Conversation

beeequeue commented Oct 15, 2025

Copy link
Copy Markdown
Member

Updates Prettier to v3.

This also means the minimum version of it as a peer dependency also gets bumped to the latest one. Maybe the peer dependency requirement should be changed to ^3?

I reverted the updated trailingCommas setting back to the v2 value to minimize the amount of formatting changes as recommended by @bluwy, but if @Andarist agrees I can revert to the default v3 config and re-format the files according to that.
(Personally I would also set the line-width to 90-100 as well, for better readability)

changeset-bot Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0a18559

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@changesets/apply-release-plan Minor
@changesets/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.43358% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.60%. Comparing base (ca0738c) to head (0a18559).
⚠️ Report is 1 commits behind head on next.

Files with missing lines Patch % Lines
packages/config/src/index.ts 80.55% 14 Missing ⚠️
packages/cli/src/commands/add/createChangeset.ts 57.14% 12 Missing ⚠️
packages/cli/src/commands/publish/npm-utils.ts 15.38% 11 Missing ⚠️
packages/cli/src/run.ts 50.00% 9 Missing ⚠️
packages/get-github-info/src/index.ts 33.33% 8 Missing ⚠️
...rc/test-utils/get-changelog-entry-with-git-hash.ts 0.00% 7 Missing ⚠️
packages/cli/src/commands/init/index.ts 53.84% 6 Missing ⚠️
...ckages/cli/src/commands/publish/publishPackages.ts 57.14% 6 Missing ⚠️
packages/changelog-github/src/index.ts 44.44% 5 Missing ⚠️
packages/assemble-release-plan/src/test-utils.ts 50.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1744      +/-   ##
==========================================
+ Coverage   80.59%   80.60%   +0.01%     
==========================================
  Files          66       66              
  Lines        5360     5363       +3     
  Branches     1026     1025       -1     
==========================================
+ Hits         4320     4323       +3     
  Misses       1033     1033              
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bluwy approved these changes Oct 16, 2025
View reviewed changes

bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I'm for the default trailing comma setting too, though given we still need to merge main into next for time to time, maybe we should hold back for now until next is nearly ready for stable.

Andarist reviewed Oct 30, 2025
View reviewed changes
Comment thread package.json Outdated
Andarist reviewed Oct 30, 2025
View reviewed changes
Comment thread .changeset/soft-sloths-burn.md Outdated
Andarist reviewed Oct 30, 2025
View reviewed changes
Comment thread .changeset/soft-sloths-burn.md Outdated

Andarist commented Oct 30, 2025

Copy link
Copy Markdown
Member

This also means the minimum version of it as a peer dependency also gets bumped to the latest one. Maybe the peer dependency requirement should be changed to ^3?

Their API is largely compatible between v2 and v3. We are using getPrettierInstance helper to resolve a local installation first and that, to the best of my knowledge, is compatible with both versions. So this change only changes what gets loaded by default if we can't find an already installed Prettier.

beeequeue commented Nov 10, 2025

Copy link
Copy Markdown
Member Author

after merging this i would recommend adding a .git-blame-ignore-revs file to exclude the formatting commit's changes from git and github's blames

bluwy mentioned this pull request Nov 17, 2025
Closed
bluwy approved these changes Dec 12, 2025
View reviewed changes
Comment thread .changeset/soft-sloths-burn.md Outdated

beeequeue commented Dec 15, 2025

Copy link
Copy Markdown
Member Author

@Andarist this is ready too

GabDug mentioned this pull request Jan 25, 2026
Merged
5 tasks

Andarist commented Mar 3, 2026

Copy link
Copy Markdown
Member

@beeequeue could you sync this with next?

Andarist merged commit 303cacd into changesets:next Mar 4, 2026
7 of 8 checks passed
github-actions Bot mentioned this pull request Mar 4, 2026
Merged
beeequeue deleted the prettier32 branch March 4, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bluwy bluwy approved these changes
Andarist Andarist approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL