FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make prettier really optional by edoardocavazza · Pull Request #1858 · changesets/changesets · GitHub

Make prettier really optional - #1858

Closed
edoardocavazza wants to merge 4 commits into
changesets:mainfrom
edoardocavazza:optional-prettier
Closed

Make prettier really optional#1858
edoardocavazza wants to merge 4 commits into
changesets:mainfrom
edoardocavazza:optional-prettier

Conversation

Copy link
Copy Markdown

Since the user can disable the use of prettier, I think it makes sense to move the dependency to peerDependencies, marking it as optional.
Importing prettier as a type when it's actually only used as a type should change nothings at runtime.

changeset-bot Bot commented Feb 26, 2026
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3cfe3ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov Bot commented Feb 26, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.86%. Comparing base (e462d89) to head (3cfe3ba).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1858   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files          55       55           
  Lines        2360     2360           
  Branches      706      705    -1     
=======================================
  Hits         1932     1932           
  Misses        423      423           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Andarist commented Mar 2, 2026
edited
Loading

Copy link
Copy Markdown
Member

Since the user can disable the use of prettier

That's not how it works. We simply prefer the Prettier version used by the project but we use the one installed by Changesets as a fallback.

Removing this would be a breaking change now. It's something we want to consider for the next major version but I don't think it's worth doing in v2

Copy link
Copy Markdown
Member

see also #1736 (comment)

Andarist closed this Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL