FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't error on symlinks and executables when they don't have to be touched anyway by Andarist · Pull Request #46 · changesets/ghcommit · GitHub

/ ghcommit Public

Don't error on symlinks and executables when they don't have to be touched anyway - #46

Merged
Andarist merged 12 commits into
mainfrom
Andarist-patch-1
Jan 27, 2026
ConversationCommits (12)ChecksFiles changed
Merged

Don't error on symlinks and executables when they don't have to be touched anyway#46
Andarist merged 12 commits into
mainfrom
Andarist-patch-1

Conversation

Andarist commented Jan 13, 2026

Copy link
Copy Markdown
Member

suggested by @dotansimha

Andarist requested a review from s0 January 13, 2026 15:10
dotansimha mentioned this pull request Jan 13, 2026
Closed

dotansimha commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

related: changesets/action#523

Don't error on symlinks and executables when they don't have to be to…
104ac00 
…uched anyway

Co-authored-by: Dotan Simha <dotan@the-guild.dev>
s0 previously approved these changes Jan 13, 2026
View reviewed changes

s0 commented Jan 13, 2026

Copy link
Copy Markdown
Member

Looks good, but integration tests need to be updated to allow for unchanged symlinks, but still throw an error for symlinks that changed and are not ignored.

s0 previously approved these changes Jan 14, 2026
View reviewed changes

s0 commented Jan 14, 2026

Copy link
Copy Markdown
Member

Hmm tests still failing

Andarist commented Jan 14, 2026

Copy link
Copy Markdown
Member Author

@s0, ye - I vibocoded them and couldn't quickly test locally because I didn't have tokens setup for the integration tests so decided to use CI to verify the change for me ;p I'll look into fixing this later

Andarist commented Jan 19, 2026

Copy link
Copy Markdown
Member Author

In the process of working on this I have diagnosed an issue in the isomorphic-git and opened a PR to address it: isomorphic-git/isomorphic-git#2271

Andarist force-pushed the Andarist-patch-1 branch 4 times, most recently from bf3055e to 6c8c084 Compare January 24, 2026 22:34
Andarist force-pushed the Andarist-patch-1 branch 3 times, most recently from a1a7daf to bcf398e Compare January 24, 2026 23:11

Andarist commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

This is now ready to be stamped and merged, cc @s0

Andarist requested review from bluwy and s0 January 26, 2026 07:50
bluwy approved these changes Jan 27, 2026
View reviewed changes

bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not familiar with this package but the code seems ok to me.

Andarist merged commit d12678c into main Jan 27, 2026
4 checks passed
Andarist deleted the Andarist-patch-1 branch January 27, 2026 17:29
github-actions Bot mentioned this pull request Jan 27, 2026
Merged

s0 commented Jan 27, 2026

Copy link
Copy Markdown
Member

Thanks for getting this over the line @Andarist 💪

Andarist mentioned this pull request May 22, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bluwy bluwy approved these changes
s0 Awaiting requested review from s0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL