FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Modernize GitHub workflows by Andarist · Pull Request #48 · changesets/ghcommit · GitHub

/ ghcommit Public

Modernize GitHub workflows - #48

Merged
s0 merged 4 commits into
mainfrom
rename-workflow-files
Jan 27, 2026
ConversationCommits (4)ChecksFiles changed
Merged

Modernize GitHub workflows#48
s0 merged 4 commits into
mainfrom
rename-workflow-files

Conversation

Andarist commented Jan 27, 2026

Copy link
Copy Markdown
Member

I've configured trusted publishing for publish.yml so we need to rename this file

Andarist requested review from bluwy and s0 January 27, 2026 07:56
bluwy reviewed Jan 27, 2026
View reviewed changes
Comment thread .github/workflows/publish.yml Outdated
Andarist mentioned this pull request Jan 27, 2026
Merged
Andarist changed the title Rename workflow files Tweak publish workflow file Jan 27, 2026
Andarist requested a review from bluwy January 27, 2026 17:36
bluwy previously approved these changes Jan 27, 2026
View reviewed changes

bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You know what would be cool? 😅 changesets/action#525

Anyways LGTM now 👍

s0 requested changes Jan 27, 2026
View reviewed changes

s0 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Couple more changes to probably get this working, see related PRs for getting trusted publishing working in another repo I maintain:

Comment thread .github/workflows/publish.yml Outdated
Comment on lines 21 to 23

s0 Jan 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Need to also upgrade these for trusted publishing to work:

        uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
        with:
          node-version: 24.x

See this PR in another repo with an equivalent change: ArcaneWizards/arcanejs#107

Andarist Jan 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I bumped all actions now

Comment thread .github/workflows/publish.yml Outdated
Comment on lines +39 to +40
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: true

s0 Jan 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: true

Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/ci.yml
Andarist changed the title Tweak publish workflow file Modernize GitHub workflows Jan 27, 2026
s0 enabled auto-merge (squash) January 27, 2026 17:52
Andarist requested a review from s0 January 27, 2026 17:52
s0 merged commit 8d5d614 into main Jan 27, 2026
4 checks passed
s0 deleted the rename-workflow-files branch January 27, 2026 17:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

s0 s0 approved these changes
bluwy bluwy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL