Allow null value for mode parameter in getParams function - #790
Open
c-oyen wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Explicitly updated the type of the `mode` parameter to `string | null` in the `getParams` function to support cases where `mode` might be `null`. This improves flexibility and handling of optional parameters.
Copy link
Copy Markdown
|
@Anrecky is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
Sorry, something went wrong.
BourezBastien
added a commit
to BourezBastien/next-drupal
that referenced
this pull request
Aug 24, 2026
…ull typing getParams() fell through without returning for unknown resource types, returning undefined instead of a DrupalJsonApiParams instance. Add a fallback return and type the mode parameter as string | null. Adopted from upstream PRs chapter-three#790 and chapter-three#791. Co-authored-by: anRecky <45596261+Anrecky@users.noreply.github.com>
BourezBastien
added a commit
to BourezBastien/next-drupal
that referenced
this pull request
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is for: (mark with an "x")
Description
Explicitly updated the type of the mode parameter to string | null in the getParams function to support cases where mode might be null. This improves flexibility and handling of optional parameters.