feat: disable pty emulation - #7
Closed
aymanbagabas wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This adds the ability to disable the session's PTY emulation from translating NL to CRLN. This is needed when allocating PTYs and applying their terminal modes from the session PTY request.
caarlos0
approved these changes
Sep 22, 2023
Copy link
Copy Markdown
Author
|
Ideally, we want to disable the emulation completely and make it opt-in using NewPtyWriter/NewPtyReadWriter. We would need to allocate a Pty for each Pty request using something like pty or go-pty. If Pty allocation failed, we could fall back to this emulation hack. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
is this still needed? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Nope |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to disable the session's PTY emulation from translating NL to CRLN. This is needed when allocating PTYs and applying their terminal modes from the session PTY request.
Reference: gliderlabs#210