FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implement per-dataset type (default and per-chart) options by benmccann · Pull Request #5999 · chartjs/Chart.js · GitHub

/ Chart.js Public

Implement per-dataset type (default and per-chart) options - #5999

Merged
simonbrunel merged 11 commits into
chartjs:masterfrom
benmccann:controller-default-opts
May 6, 2019
ConversationCommits (11)ChecksFiles changed
Merged

Implement per-dataset type (default and per-chart) options#5999
simonbrunel merged 11 commits into
chartjs:masterfrom
benmccann:controller-default-opts

Conversation

benmccann commented Jan 20, 2019

Copy link
Copy Markdown
Contributor

This fixes mixed line and scatter charts. Issue described in #4587

Closes #5997 & #5151

benmccann mentioned this pull request Jan 21, 2019
Closed
kurkle reviewed Jan 21, 2019
View reviewed changes

kurkle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

After the discussion in Slack, this seems like a good start!

Comment thread karma.conf.js Outdated
Comment thread src/controllers/controller.line.js Outdated
Comment thread src/controllers/controller.line.js Outdated
Comment thread src/core/core.datasetController.js Outdated
Comment thread src/controllers/controller.line.js Outdated
benmccann force-pushed the controller-default-opts branch 5 times, most recently from 15dd6bf to 0b86cf9 Compare January 21, 2019 18:46
simonbrunel requested changes Jan 22, 2019
View reviewed changes
Comment thread src/controllers/controller.line.js Outdated
Comment thread src/controllers/controller.scatter.js
Comment thread src/core/core.datasetController.js Outdated
Comment thread src/core/core.datasetController.js
kurkle previously approved these changes Jan 22, 2019
View reviewed changes

kurkle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me

simonbrunel reviewed Jan 23, 2019
View reviewed changes
Comment thread src/core/core.defaults.js
simonbrunel requested changes Jan 23, 2019
View reviewed changes

simonbrunel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A minor update in _defaults.

We also need unit tests per controller (line + scatter) to make sure that dataset defaults are correctly handled for every options. And I guess we also need to update the docs about configuring dataset defaults.

Comment thread src/core/core.datasetController.js Outdated
benmccann force-pushed the controller-default-opts branch from 0e541e2 to 8c89c7a Compare January 24, 2019 01:10

benmccann commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

We also need unit tests per controller (line + scatter) to make sure that dataset defaults are correctly handled for every options.

The line chart showLine option was already well tested. I added additional tests for spanGaps and for scatter's showLine.

And I guess we also need to update the docs about configuring dataset defaults.

We don't allow users to configure default options. defaults._set is private

benmccann force-pushed the controller-default-opts branch 4 times, most recently from 3c0bad6 to 1be7103 Compare January 29, 2019 17:25
kurkle requested changes Feb 1, 2019
View reviewed changes

kurkle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One line to remove and a question to consider.

Comment thread src/core/core.datasetController.js
Comment thread src/controllers/controller.line.js Outdated

simonbrunel commented Feb 1, 2019

Copy link
Copy Markdown
Member

We don't allow users to configure default options. defaults._set is private

_set is indeed an internal helper but users are allowed to modify Chart.defaults.datasets.*. So since we are introducing a new public API that allows users to configure defaults for all dataset options, we should also add unit tests for it.

benmccann commented Feb 1, 2019

Copy link
Copy Markdown
Contributor Author

Ok, I went ahead and added documentation. I had already added unit tests

nagix reviewed Feb 4, 2019
View reviewed changes
Comment thread docs/configuration/README.md Outdated
benmccann force-pushed the controller-default-opts branch 5 times, most recently from b0bd6f4 to 5c3f88f Compare February 12, 2019 04:20
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Implement per-dataset type (default and per-chart) options (chartjs#5999
b88f522 
)
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed

MatsNissen-Lie commented Jan 14, 2022

Copy link
Copy Markdown

I want to combined the candlestick chart with a line chart. Is that possible, and if so, how?

jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
mend-for-github-com Bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
mend-for-github-com Bot mentioned this pull request Jan 26, 2023
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kurkle kurkle approved these changes
simonbrunel simonbrunel approved these changes
etimberg Awaiting requested review from etimberg
+1 more reviewer
nagix nagix approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

Version 2.9

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL