Specify time scale options in standard manner - #6097
Merged
simonbrunel merged 4 commits intoApr 2, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
kurkle
reviewed
Mar 25, 2019
Comment thread
src/scales/scale.time.js
Outdated
kurkle
previously approved these changes
Mar 25, 2019
etimberg
previously approved these changes
Mar 25, 2019
nagix
previously approved these changes
Mar 26, 2019
simonbrunel
requested changes
Mar 28, 2019
simonbrunel
reviewed
Mar 28, 2019
Comment thread
src/scales/scale.time.js
Outdated
nagix
reviewed
Apr 1, 2019
Comment thread
src/scales/scale.time.js
Outdated
nagix
approved these changes
Apr 1, 2019
simonbrunel
approved these changes
Apr 1, 2019
simonbrunel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, thanks @benmccann
Sorry, something went wrong.
etimberg
approved these changes
Apr 1, 2019
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's difficult to write code that interfaces with the scale min and max options in a standard manner because the time scale puts the options in a different place than all the other scales, so everything has to be special cased to detect the time scale. This change allows reading from either the standard options.ticks location or the options.time location which this PR deprecates