Make line properties scriptable - #6128
Merged
simonbrunel merged 29 commits intoMar 21, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
etimberg
previously approved these changes
Mar 14, 2019
etimberg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Just have one minor comment. looks good!
Sorry, something went wrong.
Comment thread
test/fixtures/controller.line/backgroundColor/scriptable.js
Outdated
kurkle
previously approved these changes
Mar 14, 2019
etimberg
previously approved these changes
Mar 14, 2019
benmccann
previously approved these changes
Mar 15, 2019
simonbrunel
requested changes
Mar 16, 2019
simonbrunel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice work @janelledement!
I know it's a lot of work but I would change a few things in the unit tests. I would first make sure no element (line/point) are cut by setting layout padding. Else, some tests are useless (e.g. border cap). And I would make the scriptables simpler (no reduce()), easier to read and maintain.
Sorry, something went wrong.
Comment thread
samples/scriptable/line.html
Outdated
Comment thread
samples/scriptable/line.html
Outdated
Comment thread
src/controllers/controller.line.js
Outdated
Comment thread
src/controllers/controller.line.js
Outdated
Comment thread
test/fixtures/controller.line/backgroundColor/scriptable.js
Outdated
Comment thread
test/fixtures/controller.line/cubicInterpolationMode/scriptable.js
Outdated
Comment thread
test/fixtures/controller.line/borderCapStyle/scriptable.js
Outdated
Comment thread
test/fixtures/controller.line/cubicInterpolationMode/scriptable.js
Outdated
Comment thread
test/fixtures/controller.line/borderCapStyle/scriptable.js
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
This PR introduces scriptable capability to these line options:
Testing:
Wrote fixture tests for all the line options listed above.
Updated a test in plugin.filler.tests.js: 'should ignore invalid values'. (This test formerly listed functions as an ignored value for 'fill').
Documentation:
Updated the line chart documentation to acknowledge that these line options are also scriptable.
Updated the line sample to demonstrate scriptable background color.