Use the appropriate time format for auto tick generation - #6182
Merged
simonbrunel merged 2 commits intoApr 26, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
benmccann
previously approved these changes
Apr 4, 2019
kurkle
previously approved these changes
Apr 15, 2019
etimberg
previously approved these changes
Apr 15, 2019
etimberg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is it worth it to have a test for this?
Sorry, something went wrong.
simonbrunel
previously approved these changes
Apr 18, 2019
simonbrunel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good! I think a regression test would be useful as @etimberg suggested.
Sorry, something went wrong.
nagix
dismissed stale reviews from simonbrunel, etimberg, kurkle, and benmccann
via
da2ef6d
April 24, 2019 08:54
nagix
force-pushed
the
issue-6182
branch
2 times, most recently
from
da2ef6d to
8a03ea0
Compare
April 24, 2019 08:59
Copy link
Copy Markdown
Contributor
Author
|
A regression test was added. |
Sorry, something went wrong.
kurkle
approved these changes
Apr 24, 2019
benmccann
approved these changes
Apr 24, 2019
etimberg
approved these changes
Apr 24, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The label width is currently calculated using time.displayFormats.millisecond regardless of time.unit. This PR uses the appropriate time format for auto tick generation if time.unit is specified.
Master: https://jsfiddle.net/nagix/6fjh43xy/
This PR: https://jsfiddle.net/nagix/hfopn34g/
Fixes #4411