Assign unique scale IDs - #6291
Merged
nagix merged 1 commit intoJun 9, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
benmccann
approved these changes
May 23, 2019
kurkle
approved these changes
May 24, 2019
etimberg
approved these changes
May 26, 2019
charlesmass
pushed a commit
to charlesmass/Chart.js
that referenced
this pull request
Jun 17, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
1 task
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the first x or y scale has id: 'x-axis-1' or 'id: y-axis-1', and more scales are added without id, ID will be duplicated, and the they will not be correctly configured.
The example below shows that only 2 scales are configured in a scatter chart even if the config has 3 scales because the default scale IDs in scatter charts are 'x-axis-1' and 'y-axis-1' but the controller try to assign a number using the array index starting from 0.
This PR fixes it by checking the existing IDs to assign unique one.
Master: https://jsfiddle.net/nagix/6ar792zo/
This PR: https://jsfiddle.net/nagix/dLs956je/
