[performance] replace helpers.each calls with for-loops - #6301
Merged
etimberg merged 3 commits intoJun 22, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
benmccann
force-pushed
the
helpers-each
branch
4 times, most recently
from
b5ba6c0 to
3b0b502
Compare
May 27, 2019 04:56
etimberg
previously approved these changes
Jun 16, 2019
nagix
previously approved these changes
Jun 17, 2019
nagix
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
There might be some user applications that expect to have the scale range [-1, 1] with no data, but it does not seem to be the intention of the current implementation, and for better consistency, I'm fine with the changes in this PR.
Sorry, something went wrong.
kurkle
previously approved these changes
Jun 19, 2019
Comment thread
src/scales/scale.linear.js
Outdated
nagix
approved these changes
Jun 19, 2019
etimberg
approved these changes
Jun 19, 2019
kurkle
approved these changes
Jun 22, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* [performance] replace helpers.each calls with for-loops * Use Math.min/max instead of if statement * Rename variable
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for-loop and Math.min/max is much faster than helpers.forEach and if statements: https://jsperf.com/chartjs-helpers-each
I was focused on determineDataLimits since that's a particularly costly method that iterates over each data point. There are more places where helpers.each is called in less performance-sensitive locations where there wasn't a compelling reason to change it
The scale behavior was really inconsistent. If there was no data then the tests expected the scale to start at -1. I changed it to start at 0 instead for consistency. E.g. I would expect it to behave the same when there's no data and all data points are hidden. When all data points are hidden then the tests expect the scale to start at 0. E.g.:
Chart.js/test/specs/scale.linear.tests.js
Line 1037 in 70b32ff