[performance] faster major tick calculation - #6307
Merged
etimberg merged 3 commits intoJun 19, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nagix
reviewed
Jun 4, 2019
Comment thread
src/scales/scale.time.js
Outdated
kurkle
reviewed
Jun 4, 2019
nagix
approved these changes
Jun 6, 2019
kurkle
approved these changes
Jun 7, 2019
etimberg
approved these changes
Jun 19, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* [performance] faster major tick calculation * Address review comments * Replace isNaN
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major speedup when ticks.source is data or labels. The speed up is because it avoids calling startOf on every tick, which is expensive since it creates a moment object and does a non-trivial calculation. It's also necessary to implement #6274 efficiently. I'll rebase that PR and reopen a re-worked version of it after this change and #6304 are merged
Before:
After:
