Render charts only once in time scale tests - #6347
Merged
etimberg merged 1 commit intoJun 25, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I tend to extract tests for debugging, so haven't had this issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for taking a look. None of the tests I've changed are testing a 2nd update of scale. |
Sorry, something went wrong.
nagix
approved these changes
Jun 24, 2019
nagix
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me
Sorry, something went wrong.
etimberg
approved these changes
Jun 24, 2019
kurkle
approved these changes
Jun 25, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
1 task
1 task
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many of the time scale tests, we render the chart and then update it to some certain dimensions. This makes it very difficult to step through the code with a debugger because the first time we hit any line of code doesn't affect the ultimate state of the chart. It also makes the tests take longer to run than necessary.
This passes the dimensions into the creation function so that it's created with the correct dimensions from the beginning.