FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add elements.arc.angle in documentation by mp3000mp · Pull Request #6491 · chartjs/Chart.js · GitHub

/ Chart.js Public

Add elements.arc.angle in documentation - #6491

Merged
etimberg merged 2 commits into
chartjs:masterfrom
mp3000mp:arc-doc-angle
Sep 7, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Add elements.arc.angle in documentation#6491
etimberg merged 2 commits into
chartjs:masterfrom
mp3000mp:arc-doc-angle

Conversation

mp3000mp commented Aug 31, 2019

Copy link
Copy Markdown
Contributor

Using elements.arc.angle option can be a workaround for #4751 and make #6472 useless.

Demo here : https://jsfiddle.net/h1e78vbq/

mp3000mp mentioned this pull request Aug 31, 2019
Closed
etimberg previously approved these changes Sep 2, 2019
View reviewed changes
kurkle previously approved these changes Sep 4, 2019
View reviewed changes
benmccann reviewed Sep 4, 2019
View reviewed changes
Comment thread docs/configuration/elements.md Outdated

| Name | Type | Default | Description
| ---- | ---- | ------- | -----------
| `angle` | `number` | `circumference / (arc count)` - for polar only | Arc angle to cover.

benmccann Sep 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

what does "for polar only" mean? That the option is available only for the polar chart or that default is circumference / (arc count) only for the polar chart? If the latter, what is the default for other chart types?

mp3000mp Sep 4, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We have two types of chart using elements.arc :

  • Polar area
  • Pie/Doughnut

I tried to set elements.arc.angleoption in Pie/Doughnut chart. It doesn't override the natural angles computation.

So it seems that this option is available only for polar chart, and I think it's a good thing.

benmccann Sep 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok. I think it might be clearer to put "for polar only" next to the option name rather than the default value. How about:

angle (polar area chart only)

kurkle Sep 6, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rather than stating its for polar only, why not move it to

Chart.js/docs/charts/polar.md

Lines 58 to 68 in f68b8ad

### Styling
The style of each arc can be controlled with the following properties:
| Name | Description
| ---- | ----
| `backgroundColor` | arc background color.
| `borderColor` | arc border color.
| `borderWidth` | arc border width (in pixels).
All these values, if `undefined`, fallback to the associated [`elements.arc.*`](../configuration/elements.md#arc-configuration) options.

Like weight in pie/doughnut

mp3000mp dismissed stale reviews from kurkle and etimberg via 5e066cb September 5, 2019 22:32
etimberg merged commit 6e69a38 into chartjs:master Sep 7, 2019
snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Add elements.arc.angle in documentation (chartjs#6491)
de617df 
Add elements.arc.angle in documentation
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
mend-for-github-com Bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
mend-for-github-com Bot mentioned this pull request Jan 26, 2023
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kurkle kurkle left review comments
etimberg etimberg approved these changes
+1 more reviewer
benmccann benmccann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL